Skip to content

Code Review

Every code change in Summon goes through four-lens review. Not sequentially — in parallel.

  • Is this the simplest approach that works?
  • Will a new team member understand this in 6 months?
  • Are patterns consistent with the rest of the codebase?
  • Are there unnecessary abstractions or premature optimizations?
  • Do tests cover the change adequately?
  • Are tests testing behavior, not implementation details?
  • Are edge cases covered?
  • Would a regression be caught?
  • Are there injection vulnerabilities (SQL, XSS, command)?
  • Is authentication/authorization correct?
  • Are secrets handled properly?
  • Are dependencies safe?
  • Does this conform to the ADR for this area?
  • Are module boundaries respected?
  • Is the data flow correct?
  • Will this create coupling problems?
LevelAction
CriticalBlocks merge. Must fix.
ImportantShould fix before merge.
SuggestionConsider for improvement.
NitpickStyle preference, take it or leave it.

Only Critical and Important findings require action.

/code-review

This invokes the composite code-reviewer agent, which spawns all four lenses in parallel and consolidates findings.

Single-pass review optimizes for one perspective. A security expert misses maintainability issues. A simplicity-focused reviewer misses auth bugs. By running four lenses in parallel:

  • Each lens focuses on what it’s best at
  • No single perspective dominates
  • Review completes faster (parallel, not sequential)
  • Findings are categorized by type, making triage easier